chore: Centralise PageToken parsing#601
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the application's pagination token handling by introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable refactoring by centralizing the logic for parsing and generating page tokens into a new PageToken utility class. This change effectively removes duplicated code from JpaDatabasePushNotificationConfigStore, JpaDatabaseTaskStore, and InMemoryTaskStore, which significantly improves code clarity and maintainability. The new implementation also enforces stricter validation on page tokens, correctly throwing an error for invalid formats, which is a good improvement for robustness. The accompanying test updates accurately reflect this new behavior. I have one suggestion to further improve the validation in the new PageToken class.
ehsavoie
left a comment
There was a problem hiding this comment.
A unit test for the parsing would have been great.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Adding Unit Test
fixes: #597